Fix smooth scrolling on index doc page #6390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow the animation with Javascript was broken, as it scrolled up the top and than jupped the actual target. Since ~70% of all browser support this with pure CSS today, this should be good enough for this minor feature. The 'local' class was only used within JavaScript so it was dropped.
dottybot
reviewed
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the animation with Javascript was broken, as it scrolled up the
top and than jupped the actual target.
Since ~70% of all browser support this with pure CSS today, this should
be good enough for this minor feature.
The 'local' class was only used within JavaScript so it was dropped.